fix: specify timezone in PartitionByRangeDateHash and adjust test expectations #2963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR fixes a test failure in
PartitionByRangeDateHashTest.test()within.module by setting the timezone to UTC for all date parsing and formatting operations. It also updates the corresponding test (PartitionByRangeDateHashTest) to generate and validate timestamps in UTC for consistent results.Problem
The previous implementation of
PartitionByRangeDateHashusedSimpleDateFormatwithout specifying a timezone, which defaulted to the system’s local timezone. This caused inconsistent partition calculations and test failures when the code was run on machines in different timezones. The same input timestamp could map to a different partition depending on the local environment.Reproduce Test
Run either one of the following commands in two environments with different timezones:
The test
PartitionByRangeDateHashTestwill fail on one environment but pass on another due to timezone differences affectingSimpleDateFormatparsing.The Fix
SimpleDateFormatto use UTC for both initialization (beginDate) and parsing (formatter).PartitionByRangeDateHashTestto generate timestamps in UTC to align with the updated logic.